Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.2.1-deb] AppArmor denial causing deletion to not take effect #856

Closed
eloquence opened this issue Mar 4, 2020 · 0 comments · Fixed by #866
Closed

[0.2.1-deb] AppArmor denial causing deletion to not take effect #856

eloquence opened this issue Mar 4, 2020 · 0 comments · Fixed by #866
Assignees
@redshiftzero
Labels
release blocker security

Comments

@eloquence
Copy link
Member

eloquence commented Mar 4, 2020 •
edited
Loading

(The version identifier refers to the Debian packaging production release tag 0.2.1, not to the client package version.)

During QA, discovered that a file that was apparently deleted in the client was not deleted on disk. Inspecting the logs shows an AppArmor denial:

Mar 3 15:42:23 localhost kernel: [ 3883.626967] audit: type=1400 audit(1583278943.632:14): apparmor="DENIED" operation="open" profile="/usr/bin/securedrop-client" name="/home/user/.securedrop_client/data/" pid=1516 comm="QThread" requested_mask="r" denied_mask="r" fsuid=1000 ouid=1000
@eloquence eloquence mentioned this issue Mar 4, 2020
Closed
@eloquence eloquence mentioned this issue Mar 4, 2020
Closed
@redshiftzero redshiftzero self-assigned this Mar 4, 2020
redshiftzero added a commit that referenced this issue Mar 4, 2020
@redshiftzero
apparmor: fix denial during source deletion (#856)
8bddbce
@redshiftzero redshiftzero mentioned this issue Mar 4, 2020
Merged
6 tasks
sssoleileraaa pushed a commit that referenced this issue Mar 4, 2020
@redshiftzero @sssoleileraaa
apparmor: fix denial during source deletion (#856)
ab52f92
@rmol rmol mentioned this issue Mar 6, 2020
Closed
@eloquence eloquence mentioned this issue Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

Labels
release blocker security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

app: delete source collection when source is deleted locally freedomofpress/securedrop-client
2 participants
@eloquence @redshiftzero