message bubbles don't expand

[redshiftzero]

message bubbles (I saw this for replies at least) don't expand when the content exceeds the size of the bubble, it is instead truncated

[eloquence]

Tracked as release blocker because truncation may suggest loss of information to the user.

[sssoleileraaa]

I'm unable to repro, so if someone else can thoroughly check this issue for replies (also check messages while you're at it) and can't repro then I think we can close this issue. Here's an example of what I'm seeing:

[redshiftzero]

Hmm so I don't have solid STR, but I see this intermittently still on latest master in non-Qubes:

[eloquence]

Can't repro in Ubuntu dev env:

[sssoleileraaa]

Here's an STR for a similar issue:

1. Send a reply 100+ characters long without spaces

Expected

The word to be wrapped across multiple lines with an indicator of wrapping or a horizontal scrollbar

Actual

We cut off the word after around 97 characters

[sssoleileraaa]

Another STR for a different but related issue (this is for the preview of text):

1. Send a reply less than 180 characters but 4 lines long, e.g.

one
two
three
four

OR

1. Send a reply with word wrapping on one line that is more than 120 characters long, e.g.

Expected

three lines in the preview with a ...

Actual

Four lines in the preview, which looks a bit crowded

(minor issue but worth reporting)

[kushaldas]

I created the reply with python3 -c "print('A' * 300)"
I think this should be counted as a proof of the error.

[sssoleileraaa]

^ yup that confirms the related issue but not the original issue reported here by @redshiftzero where the speech bubble doesn't entirely resize top to bottom to fit its content: #799 (comment)

even though i can't repro, i wonder, since it's an intermittent issue, if it's because we are redrawing the speech bubble at the same time we are updating the text in the speech bubble

[eloquence]

Possibly related, seeing some extra special behavior in (Ubuntu/Docker) dev env today. This is after a sync, where a file and a message was added for an existing source.

Restarting the client resolved:

Part of this may be due to an out-of-sync issue. You'll notice that the first screenshot shows text missing in the second one -- that's from a previous test run against a previous instantiation of the dev env. But the source is brand new and should not have been associated with that text in the first place. :/ Will see if I can get STRs for that.

[sssoleileraaa]

ah this reminds me of what i saw when i did a bunch of testing here #688 (review)

the issue had to do with the way ConversationView widgets (the message and reply speech bubbles) were being added/ reordered using the new index variable inline

[sssoleileraaa]

i'll try to repro by selecting a source and sending multiple messages in one sync to that source so that the GUI has to append multiple message widgets... it looks like you saw this behavior without having to send replies, so i'll just focus on messages for now

[sssoleileraaa]

@eloquence I've tried many different scenarios and cannot come up with an STR for what you saw here: #799 (comment)

I think the only two takeaways from this issue so far are these two STRs, which I'll create issues for:

• message bubbles don't expand #799 (comment)
• message bubbles don't expand #799 (comment)

[eloquence]

I've not been able to repro either, even when nuking dev env while keeping client DB unchanged. Will keep an eye on it.

[sssoleileraaa]

Feel free to create a separate issue since I do believe it's a different issue than what @redshiftzero reported here. We can track these issues even without STRs.

[eloquence]

@redshiftzero since we've been unable to reproduce the original issue in your report (as opposed to long text truncation, tracked in #815), what do you think about deprioritizing this for now, and seeing if we can reproduce during the QA stage, while pulling in #815 for immediate work?

[redshiftzero]

yep, closing this in favor of those followups