Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source list is populating very slowly in subsequent runs of the application #577

Closed
redshiftzero opened this issue Oct 18, 2019 · 0 comments · Fixed by #626
Closed

source list is populating very slowly in subsequent runs of the application #577

redshiftzero opened this issue Oct 18, 2019 · 0 comments · Fixed by #626
Assignees
@redshiftzero
Labels
bug Something isn't working

Comments

@redshiftzero
Copy link
Contributor

Description

The source list and conversation view is populating very slowly when there is already downloaded content and sources in the local data directory. I haven't investigated why this is happening yet, and I'm only seeing it in Qubes (likely due to tor latency).

Steps to reproduce

  1. In Qubes (I'm testing in the staging environment, see the readme for more details on the different developer environments) run the client, sync all your data from your test server.
  2. Close the client.
  3. Run again with the same directory.

Expected behavior

Content already downloaded appears very rapidly

Actual behavior

There's a long lag (probably for a sync to complete?) and only then does the source list populate
@redshiftzero redshiftzero added the bug Something isn't working label Oct 18, 2019
@redshiftzero redshiftzero self-assigned this Nov 19, 2019
redshiftzero added a commit that referenced this issue Nov 19, 2019
@redshiftzero
bugfix: populate source list immediately upon login (#577)
07713fc 
the controller's update_sources() method is used to display in the
source list whatever is contained in local storage. If we wait until
after sync_api is called before calling it, there will be a delay
of potentially several seconds until the round-trip to the SecureDrop
server completes.

in this commit we call the update_sources() method immediately
upon login.
@redshiftzero redshiftzero mentioned this issue Nov 19, 2019
Merged
3 tasks
kushaldas added a commit that referenced this issue Nov 20, 2019
@kushaldas
Merge pull request #626 from freedomofpress/bugfix-577
cb9102e 
bugfix: populate source list immediately upon login (#577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: populate source list immediately upon login (#577) freedomofpress/securedrop-client
1 participant
@redshiftzero