Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move export calls to their own QThread #561

Closed
redshiftzero opened this issue Sep 23, 2019 · 0 comments · Fixed by #563
Closed

move export calls to their own QThread #561

redshiftzero opened this issue Sep 23, 2019 · 0 comments · Fixed by #563
Assignees
Labels
enhancement New feature or request

Comments

@redshiftzero
Copy link
Contributor

currently run_export_preflight_checks() and export_file_to_usb_drive() are running in the main thread. this thread is also running the main event loop for the GUI, and as such the UI won't be responsive until the calls return. we should move these two calls to their own QThread, and update the export dialog via a signal. once this is done, we can remove the manual QApplication.processEvents() call we added to ensure the dialog pops up before the first export call runs here.

@redshiftzero redshiftzero added the enhancement New feature or request label Sep 23, 2019
@redshiftzero redshiftzero self-assigned this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant