Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Export Successful" message #556

Closed
sssoleileraaa opened this issue Sep 23, 2019 · 6 comments
Closed

Add "Export Successful" message #556

sssoleileraaa opened this issue Sep 23, 2019 · 6 comments

Comments

@sssoleileraaa
Copy link
Contributor

Description

When an export is successful, there will be several Qubes popup notifications in the upper right-hand corner of the screen and a SecureDrop Export VM popup notification that says the export was successful.

If we want to add another message to the user that the export was successful from the client, we need to first agree on what the message should say, how it should look, and remove the popup from the Export VM.

You can see a video of a successful export and all the popups here: https://drive.google.com/file/d/19AXGtArSdYnqcDCTsBfkC6Y7R1Lz__0Z/view?usp=sharing

@redshiftzero
Copy link
Contributor

sick video! so I was thinking about this while working on #561 (when I was deciding how to use a usb export success signal) - I think something in the export dialog that says "Export successful!" and then letting the user click OK to close that box might be nicer since as a user I'm conditioned to look primarily at the client UI to get feedback.

@redshiftzero
Copy link
Contributor

ah right right so we have this in zeplin:

Screen Shot 2019-10-10 at 5 22 47 PM

@ninavizz
Copy link
Member

Sorta revisiting this, given the new modality of the Export overlay. Will discuss tomorrow, Allie! :)

@eloquence
Copy link
Member

We'll need to revisit this soon as the Qubes notification is going away. The above messaging/styling ("Success! $number file(s) saved to USB drive.") works for me. Obviously nicer if we can have singular/plural messages.

@ninavizz
Copy link
Member

ninavizz commented Jan 9, 2020

If we can't do singular/plural, I don't think anyone would wince or be confused if we just went with plural-only files for Beta, then did plural/singular as an enhancement.

@eloquence
Copy link
Member

The client does show an "export successful" message now, so closing this issue. Polish of that message is tracked in #713.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants