Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update_version.sh to automate version bumps for nightly builds #407

Closed
eloquence opened this issue Jun 7, 2019 · 2 comments · Fixed by freedomofpress/securedrop-builder#58
Assignees

Comments

@eloquence
Copy link
Member

We're working towards nightly builds of the securedrop-client and securedrop-proxy packages (freedomofpress/securedrop-builder#8). Each nightly build will have a unique version string.

The nightly build job will automatically make a commit to this repository, updating the version string. To do so, this repository should provide an update_version.sh script (the naming convention was established in the SecureDrop repository) that performs this version bump.

Part of this task is building consensus on the version string format and the increment policy during development. One requirement is that each version string must be unique, not just at the day level resolution, as we may want to kick off builds manually in between nightly runs.This could be satisfied, for example, by a format for development releases like 0.1.0-dev-20190607-121822 (with date and time) .

@redshiftzero
Copy link
Contributor

status of this ticket: #422 contains the update_version.sh script that is needed here - but I'm leaving this ticket open and unassigned as the remaining task here is determining a good versioning scheme for the nightly builds of securedrop-client

@redshiftzero redshiftzero self-assigned this Jun 18, 2019
@redshiftzero
Copy link
Contributor

redshiftzero commented Jun 18, 2019

Looks like $latest_release_tag-dev-$timestamp does what we want here:

  • devs will upgrade to latest nightly from latest prod release:
$ dpkg --compare-versions 0.0.8-dev-20190607-121822 gt 0.0.8 && echo true
true
  • devs will upgrade from nightly release to subsequent nightly release:
$ dpkg --compare-versions 0.0.8-dev-20190608-000000 gt 0.0.8-dev-20190607-121823 && echo true
true
  • if there's a more recent prod tag than the nightly release, devs will upgrade to that:
$ dpkg --compare-versions 0.0.8-dev-20190607-121823 lt 0.0.9 && echo true
true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants