Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy in the CI #26

Closed
kushaldas opened this issue Sep 13, 2018 · 2 comments
Closed

Add mypy in the CI #26

kushaldas opened this issue Sep 13, 2018 · 2 comments

Comments

@kushaldas
Copy link
Contributor

mypy should run as part of CI.
@mdrose mdrose mentioned this issue Oct 22, 2018
Closed
@heartsucker
Copy link
Contributor

I suggest we close this ticket and merge it with #25. Adding annotations but not a CI check will be an awkward blocker toward getting everything typed. It will also mean other PRs that land between #25 this ticket will undo the work of #25.

@redshiftzero
Copy link
Contributor

agree with @heartsucker, closing in favor of #25

legoktm pushed a commit that referenced this issue Dec 15, 2023
@kushaldas
Merge pull request #26 from freedomofpress/fix-headers-post-requests
74f0007 
Send headers for POST requests sent directly to server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kushaldas @heartsucker @redshiftzero