Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for viewing downloaded documents #20

Closed
eloquence opened this issue Sep 11, 2018 · 4 comments · Fixed by #113
Closed

Add support for viewing downloaded documents #20

eloquence opened this issue Sep 11, 2018 · 4 comments · Fixed by #113

Comments

@eloquence
Copy link
Member

As a journalist I want to be able to view a file submitted by a source in a common format (e.g., PDF, JPG, DOC, AVI) so that I can inspect it for potential newsworthiness.

As shown in the messaging prototype, after a document has been downloaded, it should be possible to launch an appropriate viewer application to open a decrypted submission, ideally in a hardened disposable VM.

@eloquence eloquence added this to the 0.1alpha milestone Sep 11, 2018
@redshiftzero redshiftzero changed the title Add support for viewing downloaded documents Add support for decrypting and viewing downloaded documents Oct 25, 2018
@redshiftzero redshiftzero changed the title Add support for decrypting and viewing downloaded documents Add support for viewing downloaded documents Oct 25, 2018
@redshiftzero
Copy link
Contributor

Hey @ntoll this is the next highest priority ticket, which to replace the on click handler associated with the open button (that appears when a file is downloaded):

screen shot 2018-11-04 at 7 30 28 pm

with a handler that will open the file. The desired behavior of the file handler is:

  • On Qubes: subprocess out to qvm-open-in-vm '$dispvm:sd-svs-disp' filename (we'll have someone test your PR on Qubes to ensure that this part works as anticipated)

  • On non-Qubes: ideally we'd subprocess out to either xdg-open filename (linux) or open filename (macOS), but as this is for developers only, getting open working is not super important and we can just log a line to indicate that user opened file <filename>, and that open is supported on Qubes only

The proxy attribute here determines if the client is being executed on Qubes or not (True for Qubes, False for non-Qubes).

@kushaldas
Copy link
Contributor

On non-Qubes: ideally we'd subprocess out to either xdg-open filename (linux) or open filename (macOS), but as this is for developers only, getting open working is not super important and we can just log a line to indicate that user opened file , and that open is supported on Qubes only

👍 to this. Only logging a line in case of non-Qubes system sounds so better.

@ntoll
Copy link
Contributor

ntoll commented Nov 5, 2018

On it. :-)

@ninavizz
Copy link
Member

ninavizz commented Nov 5, 2018

Still from prototype that demonstrates opening a doc in a Disposable VM. Note: activity messaging (top-left of screen) and dialog that appears to let the user know what's going on for the 3-5sec it will take to boot the Disposable VM. Implemented as-shown here, a Beta goal—leaving here for reference. https://projects.invisionapp.com/share/R8OODHKSWY3#/screens/326625556

legoktm pushed a commit that referenced this issue Dec 15, 2023
readme: Remove line saying it isn't recommended project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment