Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize developer tooling across components #1773

Open
legoktm opened this issue Jan 18, 2024 · 0 comments
Open

Centralize developer tooling across components #1773

legoktm opened this issue Jan 18, 2024 · 0 comments
Labels
⚙️ Tooling Improving maintainability and increasing maintainer joy : )

Comments

@legoktm
Copy link
Member

legoktm commented Jan 18, 2024

Description

Currently each Python component has its own black, isort, flake8, etc. We should instead have a top-level pyproject.toml + Makefile that runs all of those across every Python file in the repo. This will cut down on the number of duplicated dependencies and make it easier for CI and hopefully, developers too.

Tools that rely on being installed in the same virtualenv, like pytest and mypy should probably not be centralized, unless it actually works out fine!

@legoktm legoktm added the ⚙️ Tooling Improving maintainability and increasing maintainer joy : ) label Jan 18, 2024
legoktm added a commit that referenced this issue Feb 8, 2024
Both of these projects can be run centrally across all components and
don't need to be installed and configured separately four times.

This also identifies and fixes that bandit wasn't being run on export
(though the issue it flagged was a false positive).

Refs #1773.
legoktm added a commit that referenced this issue Feb 12, 2024
Both of these projects can be run centrally across all components and
don't need to be installed and configured separately four times.

This also identifies and fixes that bandit wasn't being run on export
(though the issue it flagged was a false positive).

Refs #1773.
legoktm added a commit that referenced this issue Feb 22, 2024
Run black and isort from the root and apply it unconditionally to every
file in the repository.

Refs #1773.
legoktm added a commit that referenced this issue Feb 22, 2024
Run black and isort from the root and apply it unconditionally to every
file in the repository.

Refs #1773.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Tooling Improving maintainability and increasing maintainer joy : )
Projects
None yet
Development

No branches or pull requests

1 participant