Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model more-unified handling of Reply and Message objects #1617

Closed
cfm opened this issue Jan 4, 2023 · 2 comments
Closed

model more-unified handling of Reply and Message objects #1617

cfm opened this issue Jan 4, 2023 · 2 comments
Assignees
Labels
architecture database SQLite, SQLAlchemy, and data model research

Comments

@cfm
Copy link
Member

cfm commented Jan 4, 2023

Between #1493 and #1486, we discovered the following asymmetries in how messages (i.e., of different kinds and directions) are handled in the Client:

  1. DraftReply objects are separate from, rather than states of, Reply objects;
  2. Reply objects are separate from, rather than directions of, Message objects (granted, they are in the Server's data model too);
  3. replies sent to the Journalist API can be pending, successful, or failed; and
  4. messages (including replies) reported by the Journalist API can be not yet downloaded, downloaded, or failed.

This is a stub ticket to track an effort to consider and model to what extent we can resolve these asymmetries into one (Message) or two (Message and Reply) well-defined state machine/s (a) entirely Client-side or (b) with changes also to the Journalist API and its backing data model.

@cfm cfm added research database SQLite, SQLAlchemy, and data model architecture labels Jan 4, 2023
@cfm cfm self-assigned this Jan 4, 2023
@cfm
Copy link
Member Author

cfm commented Jan 24, 2023

My working model is available in https://gist.github.com/cfm/2ca373e7ac5e5397550d7db98289dc3d, which I'll write up in a formal proposal this week.

cfm added a commit that referenced this issue Mar 1, 2023
…eplyJob

In f0040bc, this was insight[1] that originally motivated #1617.[1]

[1]: #1493 (comment)
cfm added a commit that referenced this issue Apr 13, 2023
…eplyJob

In f0040bc, this was insight[1] that originally motivated #1617.[1]

[1]: #1493 (comment)
@cfm
Copy link
Member Author

cfm commented Jan 19, 2024

We dropped this in #1632 (comment).

@cfm cfm closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture database SQLite, SQLAlchemy, and data model research
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant