Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecureDrop Client does not create seen records for users who have never sent a reply #1198

Open
eloquence opened this issue Dec 9, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@eloquence
Copy link
Member

eloquence commented Dec 9, 2020

Steps to reproduce

  1. Log in via Journalist Interface as a user who has never sent a reply (user A)
  2. Submit a new message or file as a source
  3. Download it via the JI
  4. Now log in as a different user via the SecureDrop Client (user B)

Note: The same behavior can be observed by using two SecureDrop Clients with separate client directories.

Expected behavior

Upon sync, the client database should record that user A has seen the message or file, in the seen_messages or seen_files tables.

Actual behavior

The seen data is never added (#1197 will ensure that we still show a correct global seen state for the source, by interpreting the legacy downloaded / is_read flag Boolean; once that PR lands, there are no obvious UX implications from this issue).

Notes

This is because we rely on reply attribution before we create users other than the logged in user, and we don't add seen records if we don't have a user to associate them with. #1157 is expected to resolve this and other issues related to user synchronization.

@eloquence eloquence added the bug Something isn't working label Dec 9, 2020
@eloquence
Copy link
Member Author

Per my comment on #1197 (comment), since there are no immediate UX implications once that PR lands, and we get pristine seen data on each sync, I don't think this is a release blocker for 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant