-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize user data via /users endpoint #1157
Comments
We don't expect to resolve yet during the 10/28-11/12 sprint, but will do an initial technical investigation & scoping (1-2 hours max). |
Given the number of areas of the code where this is relevant (replies, seen data, login badge), this is not a small issue, so during the 11/12-11/25 @creviera and I will focus on finalizing scope and test plan/acceptance criteria. |
I think this issue should be addressed in this order: #1143 (comment) |
I edited #1143 (comment) by adding step 0 to the task order, which gets us half way there towards user sync. Once we resolve user deletion issues server side we entirely resolve this issue (in step 5). The benefit to getting half-way there with syncing on user creation is that we can begin implementing the seen-by feature at the per-message level. Currently we're blocked on working on this feature because we rely on the replies sync to create users, and not all users have sent a reply. Kudos to @eloquence for bringing this to my attention and coming up with this idea. So to get half-way there on synchronizing user data, we need to:
|
Once freedomofpress/securedrop-sdk#131 is merged and an updated SDK is released, we can use the new
/users
endpoint added in SecureDrop 1.6.0 to keep the client's user DB in sync (as part of a regular sync), instead of relying on other information, such as the attribution of replies, to infer that a user should be added to or removed from the client database. This should also help to resolve #1143.The text was updated successfully, but these errors were encountered: