Skip to content

Commit

Permalink
Merge pull request #1896 from freedomofpress/1673-no-more-hooks
Browse files Browse the repository at this point in the history
chore: remove pre-commit hooks
  • Loading branch information
cfm authored Mar 11, 2024
2 parents 94ebad8 + 17f698e commit a4fbac4
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
4 changes: 0 additions & 4 deletions client/.githooks/pre-commit

This file was deleted.

6 changes: 0 additions & 6 deletions client/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ all: help
PYTHON := $(if $(shell bash -c "command -v python3.9"), python3.9, python3)
VERSION_CODENAME ?= bullseye

HOOKS_DIR=.githooks

.PHONY: hooks
hooks: ## Configure Git to use the hooks provided by this repository.
git config core.hooksPath "$(HOOKS_DIR)"

SEMGREP_FLAGS := --exclude "tests/" --error --strict --verbose

.PHONY: semgrep
Expand Down
4 changes: 0 additions & 4 deletions client/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ poetry install
```

* You will need Python 3.9 to run the client. If it's not the default `python3` on your installation, you can set `poetry env use python3.9`.
* You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI.

4. Run SecureDrop Client

Expand Down Expand Up @@ -114,8 +113,6 @@ cd securedrop-client
poetry install
```

* You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI.

4. Run SecureDrop Client

```
Expand Down Expand Up @@ -169,7 +166,6 @@ socat TCP4-LISTEN:8081,fork,reuseaddr TCP4:A.B.C.D:8081
cd securedrop-client
poetry install
```
* You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI.

5. Run SecureDrop Client
```
Expand Down

0 comments on commit a4fbac4

Please sign in to comment.