Add a bullseye builder #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@legoktm you can add your key to https://github.com/freedomofpress/securedrop-debian-packaging/tree/main/pubkeys |
|
Does this conflict with #301 in any way? |
Duplicate the current dockerfiles/ directory into a separate buster and bullseye directories with the understanding that the buster one is going to go away pretty soon, so it's not worth abstracting the logic to be platform agnostic. I dropped some packages and the timezone step that were already present in the base `debian:bullseye` image.
This merely builds a 3.9 wheel for Cython and updates all the associated files for the new wheel. With this, it's possible to install the bootstrap in a bullseye container.
sssoleileraaa
approved these changes
May 11, 2022
There was a problem hiding this comment.
Spoke to @legoktm, did a code walkthrough, and agreed to do more testing (than just building the container locally) post merge so that we can confirm that we can successfully build a workstation component for bullseye. Since we are about to build 9 components, we'll have plenty of opportunity to work out any issues that may arise.
re: #317 (comment), this shouldn't conflict with #301 which adds bullseye build logic for a metapackage.
|
quay.io/freedomofpress/packaging-debian-bullseye:2022_05_10 has now been pushed. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate the current dockerfiles/ directory into a separate buster
and bullseye directories with the understanding that the buster
one is going to go away pretty soon, so it's not worth abstracting
the logic to be platform agnostic.
I dropped some packages and the timezone step that were already present
in the base
debian:bullseyeimage.I added my PGP key to the trusted set and rebuilt the Cython wheel for Python 3.9,
so now the bootstrap is installable in the bullseye container.
Note: I have not yet pushed the image to quay.io.