Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizes mimetype declarations for template consolidation #198

Merged
merged 7 commits into from
Oct 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,13 @@ securedrop-workstation-grsec: ## Builds Debian metapackage for Qubes Workstation
PKG_NAME="securedrop-workstation-grsec" ./scripts/build-debianpackage

.PHONY: securedrop-workstation-svs-disp
securedrop-workstation-svs-disp: ## Builds Debian metapackage for Disposable VM dependencies and tooling
securedrop-workstation-svs-disp: ## Builds Debian metapackage for Disposable VM dependencies and tooling (DEPRECATED)
PKG_NAME="securedrop-workstation-svs-disp" ./scripts/build-debianpackage

.PHONY: securedrop-workstation-viewer
securedrop-workstation-viewer: ## Builds Debian metapackage for Disposable VM dependencies and tooling
PKG_NAME="securedrop-workstation-viewer" ./scripts/build-debianpackage

.PHONY: securedrop-export
securedrop-export: ## Builds Debian package for Qubes Workstation export scripts
PKG_NAME="securedrop-export" ./scripts/build-debianpackage
Expand Down
2 changes: 0 additions & 2 deletions securedrop-export/debian/securedrop-export.install
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
files/application-x-sd-export.xml usr/share/mime/packages
files/send-to-usb.desktop usr/share/applications
files/sd-logo.png usr/share/securedrop/icons
files/mimeapps.list usr/share/applications/
files/open-in-dvm.desktop usr/share/applications/
6 changes: 6 additions & 0 deletions securedrop-workstation-config/debian/changelog-buster
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
securedrop-workstation-config (0.1.5+buster) unstable; urgency=medium

* Adds a "default" mimetype handler, for reuse by other VMs

-- SecureDrop Team <[email protected]> Thu, 01 Oct 2020 17:55:53 -0700

securedrop-workstation-config (0.1.4+buster) unstable; urgency=medium

* Provides mime type files all VMs for template consolidation
Expand Down
5 changes: 4 additions & 1 deletion securedrop-workstation-config/debian/postinst
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,15 @@ set -e
case "$1" in
configure)
# move pax flags and restart paxctld service
# copy and set default mimeapps handling
# except for whonix-based VMs
if [ ! -e "/etc/whonix_version" ]; then
cp /opt/sdw/paxctld.conf /etc/paxctld.conf
systemctl restart paxctld
cp /opt/sdw/open-in-dvm.desktop /usr/share/applications/
cp /opt/sdw/mimeapps.list.sd-app /usr/share/applications/mimeapps.list
cp /opt/sdw/mimeapps.list.sd-app /opt/sdw/mimeapps.list.default
fi
cp /opt/sdw/open-in-dvm.desktop /usr/share/applications/
;;

abort-upgrade|abort-remove|abort-deconfigure)
Expand Down
7 changes: 7 additions & 0 deletions securedrop-workstation-svs-disp/debian/changelog-buster
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
securedrop-workstation-svs-disp (0.2.3+buster) unstable; urgency=medium

* Removes mimetype handling logic, now handled in the
'securedrop-workstation-config' package.

-- SecureDrop Team <[email protected]> Fri, 11 Sep 2020 11:03:11 -0700

securedrop-workstation-svs-disp (0.2.2+buster) unstable; urgency=medium

* Fix mime type handling for desktop files
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
mimeapps.list usr/share/applications/
paxctld.conf.svsdisp opt/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pax flags are also handled by the config package[1] , we can also remove this and relevant postinst chances

Given that this package will not be installed in consolidated template, we don't strictly need to add this here, we can just remove all the workstation-svs-disp related stuff after we release consolidated templates.

[1] https://github.com/freedomofpress/securedrop-debian-packaging/pull/190/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just remove all the workstation-svs-disp related stuff after we release consolidated templates.

Right, that was my plan: we'll circle back and delete all these packages once the release has shipped. I don't see a pressing need to do that right now.

31 changes: 0 additions & 31 deletions securedrop-workstation-svs-disp/mimeapps.list

This file was deleted.

12 changes: 12 additions & 0 deletions securedrop-workstation-viewer/debian/changelog-buster
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
securedrop-workstation-viewer (0.1.1+buster) unstable; urgency=medium

* Fixes typo in control fields, replaces package
'securedrop-workstation-svs-disp'

-- SecureDrop Team <[email protected]> Mon, 05 Oct 2020 16:59:56 -0700

securedrop-workstation-viewer (0.1.0+buster) unstable; urgency=medium

* Creates package, replacing 'securedrop-workstation-sd-svs-disp' package

-- SecureDrop Team <[email protected]> Thu, 01 Oct 2020 17:36:58 -0700
1 change: 1 addition & 0 deletions securedrop-workstation-viewer/debian/compat
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
9
15 changes: 15 additions & 0 deletions securedrop-workstation-viewer/debian/control
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
Source: securedrop-workstation-viewer
Section: unknown
Priority: optional
Maintainer: SecureDrop Team <[email protected]>
Build-Depends: debhelper (>= 9),
Standards-Version: 3.9.8
Homepage: https://github.com/freedomofpress/securedrop-debian-packaging

Package: securedrop-workstation-viewer
Architecture: all
Depends: securedrop-workstation-config,securedrop-workstation-grsec,apparmor-profiles,apparmor-profiles-extra,apparmor-utils,audacious,eog,evince,file-roller,gedit,totem
Description: This is the SecureDrop workstation SecureDrop Viewer Disposable VM template configuration package. This package provides dependencies and configuration for the Qubes SecureDrop workstation sd-viewer Template VM.
Provides: securedrop-workstation-svs-disp
Conflicts: securedrop-workstation-svs-disp
Replaces: securedrop-workstation-svs-disp
7 changes: 7 additions & 0 deletions securedrop-workstation-viewer/debian/copyright
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: securedrop-workstation-svs-disp
Source: https://github.com/freedomofpress/securedrop-debian-packaging

Files: *
Copyright: 2020 Freedom of the Press Foundation <[email protected]>
License: GPLv3+
4 changes: 4 additions & 0 deletions securedrop-workstation-viewer/debian/rules
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/make -f

%:
dh $@