Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI breakage for the reproducible wheels using extensions #253

Closed
kushaldas opened this issue Jul 7, 2021 · 0 comments · Fixed by #254
Closed

CI breakage for the reproducible wheels using extensions #253

kushaldas opened this issue Jul 7, 2021 · 0 comments · Fixed by #254

Comments

@kushaldas
Copy link
Contributor

Our CI for reproducible wheels is using CircleCI's Python 3.7 container image. Which installs the latest Python from source, thus it has a different version of Python and also totally different CFLAGS.

https://circleci.com/api/v1.1/project/github/freedomofpress/securedrop-debian-packaging/8970/output/102/0?file=true&allocation-id=60e3091a6147e451fc8f1ff6-0-build%2F52B5BD2F contains one such example failure.

Below are the values from container:

 'PY_BUILTIN_MODULE_CFLAGS': '-Wno-unused-result -Wsign-compare -DNDEBUG -g '
                             '-fwrapv -O3 -Wall -std=c99 -Wextra '
                             '-Wno-unused-result -Wno-unused-parameter '
                             '-Wno-missing-field-initializers '
                             '-Wno-cast-function-type '
                             '-Werror=implicit-function-declaration '
                             '-fprofile-use -fprofile-correction -I. '
                             '-I./Include -fPIC -DPy_BUILD_CORE_BUILTIN',
 'PY_CFLAGS': '-Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall',
 'PY_CFLAGS_NODIST': '-std=c99 -Wextra -Wno-unused-result '
                     '-Wno-unused-parameter -Wno-missing-field-initializers '
                     '-Wno-cast-function-type '
                     '-Werror=implicit-function-declaration -fprofile-use '
                     '-fprofile-correction',
 'PY_COERCE_C_LOCALE': 1,
 'PY_CORE_CFLAGS': '-Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 '
                   '-Wall -std=c99 -Wextra -Wno-unused-result '
                   '-Wno-unused-parameter -Wno-missing-field-initializers '
                   '-Wno-cast-function-type '
                   '-Werror=implicit-function-declaration -fprofile-use '
                   '-fprofile-correction -I. -I./Include -fPIC -DPy_BUILD_CORE',

And here are the values from a standard Debian Buster system

 'PY_BUILTIN_MODULE_CFLAGS': '-Wno-unused-result -Wsign-compare -DNDEBUG -g '
                             '-fwrapv -O2 -Wall -g   -fstack-protector-strong '
                             '-Wformat -Werror=format-security  -g -flto '
                             '-fuse-linker-plugin -ffat-lto-objects -std=c99 '
                             '-Wextra -Wno-unused-result -Wno-unused-parameter '
                             '-Wno-missing-field-initializers '
                             '-Wno-cast-function-type '
                             '-Werror=implicit-function-declaration -IObjects '
                             '-IInclude -IPython -I. -I../Include -Wdate-time '
                             '-D_FORTIFY_SOURCE=2 -fPIC '
                             '-DPy_BUILD_CORE_BUILTIN',
 'PY_CFLAGS': '-Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall '
              '-g   -fstack-protector-strong -Wformat -Werror=format-security  '
              '-g -flto -fuse-linker-plugin -ffat-lto-objects',
 'PY_CFLAGS_NODIST': '-std=c99 -Wextra -Wno-unused-result '
                     '-Wno-unused-parameter -Wno-missing-field-initializers '
                     '-Wno-cast-function-type '
                     '-Werror=implicit-function-declaration',
 'PY_COERCE_C_LOCALE': 1,
 'PY_CORE_CFLAGS': '-Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 '
                   '-Wall -g   -fstack-protector-strong -Wformat '
                   '-Werror=format-security  -g -flto -fuse-linker-plugin '
                   '-ffat-lto-objects -std=c99 -Wextra -Wno-unused-result '
                   '-Wno-unused-parameter -Wno-missing-field-initializers '
                   '-Wno-cast-function-type '
                   '-Werror=implicit-function-declaration -IObjects -IInclude '
                   '-IPython -I. -I../Include -Wdate-time -D_FORTIFY_SOURCE=2 '
                   '-fPIC -DPy_BUILD_CORE',
 'PY_CPPFLAGS': '-IObjects -IInclude -IPython -I. -I../Include -Wdate-time '
                '-D_FORTIFY_SOURCE=2',

@kushaldas kushaldas changed the title CI breage for the reproducible wheels using extensions CI breakage for the reproducible wheels using extensions Jul 7, 2021
kushaldas added a commit that referenced this issue Jul 9, 2021
This PR adds a new container and also uses it in the CircleCI
to test reproducible wheels and Debian packages. The container
is based on standard Debian Buster, thus having the same version
of Python and environment.
kushaldas added a commit that referenced this issue Jul 9, 2021
This PR adds a new container and also uses it in the CircleCI
to test reproducible wheels and Debian packages. The container
is based on standard Debian Buster, thus having the same version
of Python and environment.
kushaldas added a commit that referenced this issue Jul 9, 2021
This PR adds a new container and also uses it in the CircleCI
to test reproducible wheels and Debian packages. The container
is based on standard Debian Buster, thus having the same version
of Python and environment.
sssoleileraaa added a commit that referenced this issue Jul 27, 2021
Fixes #253 adds reproducible testing container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant