Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debs for SecureDrop 1.7.0-rc3 (xenial+focal) #84

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

sssoleileraaa
Copy link
Contributor

Status

Ready for review

Description of changes

Adds SecureDrop 1.7.0-rc3 packages, towards freedomofpress/securedrop#5689

Test Plan

Xenial build logs can be found: freedomofpress/build-logs@93bef8a
Focal build logs can be found: freedomofpress/build-logs@8b57c54

The errors in the build logs are due to a known issue that I'll link to in a followup comment.

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like git-lfs wasn't configured when committing these. When I check out this branch locally, I see:

HEAD is now at 8e06d3b Add debs for SecureDrop 1.7.0-rc3 (Focal)
Encountered 6 file(s) that should have been pointers, but weren't:
	securedrop-app-code_1.7.0~rc3+focal_amd64.deb
	securedrop-app-code_1.7.0~rc3+xenial_amd64.deb
	securedrop-config-0.1.3+1.7.0~rc3-amd64.deb
	securedrop-keyring-0.1.4+1.7.0~rc3-amd64.deb
	securedrop-ossec-agent-3.6.0+1.7.0~rc3-amd64.deb
	securedrop-ossec-server-3.6.0+1.7.0~rc3-amd64.deb

If you view "files changed" here vs, say, #82, you can see that GitHub is correctly not labelling these lfs files.

There's also a .tar.gz that should be removed.

@conorsch conorsch mentioned this pull request Jan 20, 2021
2 tasks
@conorsch
Copy link
Contributor

Refetched branch after changes, verified all checksums locally matched what's shown in the build logs. It's worth noting that the Xenial deb files showed an error on the apt updates check: freedomofpress/build-logs@93bef8a#diff-3aa7de48727bdfacafd9c9910dfa12762106d8c0256d27b28b37a5262a7533ebR788

After discussing with @creviera, we decided to press on with rc3 anyway. Closer to final release date, we'll certainly want to update the builder image, but I'd suggest we do that on release day to avoid doing it twice.

@conorsch conorsch merged commit 4f1f15f into main Jan 20, 2021
@conorsch conorsch deleted the securedrop-1.7.0-rc3 branch August 30, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants