This repository has been archived by the owner on Sep 10, 2020. It is now read-only.
Simplifies group membership update task #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
commented
Nov 30, 2016
| with_together: | ||
| - "{{ groups_result.results }}" | ||
| - "{{ fpsd_database_usernames }}" | ||
| failed_when: true |
There was a problem hiding this comment.
failed_when: true seems like a mistake, but it doesn't always trigger due to the when: conditional. Either way, not a problem anymore.
conorsch
force-pushed
the
simplify-group-membership-tasks
branch
from
d70436e to
436e065
Compare
|
Rebased on top of latest master, given merge of #57. No conflicts. |
The original intent here is to add all authorized users to the `fpsd` group so that developers can run commands as the `fpsd` service account without directly su'ing as the service account user. Makes sense. The previous implementation was using a two-pass approach to accommodate for improper idempotence handling in Ansible's `user` module. Was able to reproduce the issue reliably on Ansible v2.1.1, but Ansible v2.2.0 has resolved the issue, and the role applies cleanly on multiple runs with the new one-task approach.
conorsch
force-pushed
the
simplify-group-membership-tasks
branch
from
436e065 to
dad2278
Compare
|
Rebased on top of latest master, given merge of #89. (We needed the tbb version bump, since the Travis tests were failing on a 404 due to old version.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent here is to add all authorized users to the
fpsdgroup so that developers can run commands as the
fpsdservice accountwithout directly su'ing as the service account user. Makes sense.
The previous implementation was using a two-pass approach to accommodate
for improper idempotence handling in Ansible's
usermodule. Was ableto reproduce the issue reliably on Ansible v2.1.1, but Ansible v2.2.0
has resolved the issue, and the role applies cleanly on multiple runs
with the new one-task approach.