Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements in our release instructions and scripts #875

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented Jul 23, 2024

Make the following improvements to our release instructions and scripts:

  1. Add a way to check if the installed Python version is the expected one.
  2. Install the Thunar file manager in our Dangerzone container environments.
  3. Do not use the builder cache by default, when building the Dangerzone container image. Add instead the --use-cache flag, when the developer wants to expedite the process for non-release builds.

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apyrgio
Copy link
Contributor Author

apyrgio commented Aug 9, 2024

For this particular change, I'll wait for our CI to become green again before I merge. Thanks for the review Kunal!

@almet
Copy link
Contributor

almet commented Aug 27, 2024

(Just rebased on latest main)

@apyrgio apyrgio added this to the 0.8.0 milestone Sep 10, 2024
Do not use by default the builder cache, when we build the Dangerzone
container image. This way, we can always have the most fresh result when
we run the `./install/common/build-image.py` command.

If a dev wants to speed up non-release builds, we add the `--use-cache`
flag to use the builder cache.
Install Thunar in our Dangerzone Linux environments, so that we can use
it for our drag-and-drop QA test.
@apyrgio apyrgio merged commit 3002849 into main Sep 10, 2024
18 of 20 checks passed
@apyrgio apyrgio deleted the 2024-07-release-extra branch September 10, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants