Temporarily pin PyMuPDF==1.23.8 in container #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeplow
commented
Feb 12, 2024
|
Some fixes in the commit message:
swapped the
with our stdout
breathing room |
PyMuPDF 1.23.9 swapped the new fitz implementation (fitz_new) with the fitz module. In the new module there are prints in the code that interfere with our stdout for sending JSON from the container. Pinning the version seems to have no adverse consequences [1], since fitz_old hasn't had significant changes and it gives breathing room for the print-related issue to be tackled in PR [2]. Fixes temporarily #700 [1]: #700 (comment) [2]: pymupdf/PyMuPDF#3137
deeplow
force-pushed
the
700-fitz-old-new
branch
from
739e104
to
3fb797c
Compare
apyrgio
approved these changes
Feb 12, 2024
|
Merging this. The failing should be unrelated to this PR (they are also happening on main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMuPDF 1.23.9 made the swapped the new fitz implementation (fitz_new) with the fitz module. In the new module there are prints in the code that interfere with our stderror for sending JSON from the container. Pinning the version seems to have no adverse consequences, since fitz_old hasn't had significant changes and it gives breething room for the print-related issue to be tackled in this PR.
Fixes temporarily #700