Make progress reports work on Qubes #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeplow
force-pushed
the
429-qubes-progress
branch
4 times, most recently
from
797ad92
to
5b5f6eb
Compare
|
General comment:
(scratch that, I didn't think the messages through :-/) |
apyrgio
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Looks good. Just to make sure, with regards to this point in #429:
Stage 1 (Document to Pixels) - we need to detect the progress as pages arrive from the disposable qube
there's no change in this PR, right? I mean, we already reported progress reports as soon as we read each page, right?
That's right. that part already happened. |
stdout_callback is used to flow progress information from the conversion to some front-end. It was always used in tandem with printing to the terminal (which is kind of a front-end). So it made sense to put them always together.
deeplow
force-pushed
the
429-qubes-progress
branch
from
5b5f6eb
to
ef41cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429. Depends on #437.