Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

50% shows twice in CLI conversion output #715

Closed
deeplow opened this issue Feb 15, 2024 · 0 comments · Fixed by #718
Closed

50% shows twice in CLI conversion output #715

deeplow opened this issue Feb 15, 2024 · 0 comments · Fixed by #718

Comments

@deeplow
Copy link
Contributor

deeplow commented Feb 15, 2024

(originally found in 0.6.0 QA) 50% progress is repeated twice. We should have one of them be like up to 45% to avoid this repetition

noticed
deeplow added a commit that referenced this issue Feb 15, 2024
@deeplow
Don't show 50% duplicated progress info
4e1ea52 
50% would show twice in the conversion progress due to an overlap in
conversion progress values. The doc_to_pixels would be from 0-50% and
the pixels_to_pdf from 50%-100%.

This commit makes the first part go from 0 to 49% instead.

Fixes #715
@deeplow deeplow mentioned this issue Feb 15, 2024
Merged
deeplow added a commit that referenced this issue Feb 20, 2024
@deeplow
Don't show 50% duplicated progress info
438b4bc 
50% would show twice in the conversion progress due to an overlap in
conversion progress values. The doc_to_pixels would be from 0-50% and
the pixels_to_pdf from 50%-100%.

This commit makes the first part go from 0 to 49% instead.

Fixes #715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't show 50% duplicated progress info freedomofpress/dangerzone
1 participant
@deeplow