Return the actual bound address, not a hardcoded "localhost". #68
Conversation
| this._nsIUDPSocket.init(port, false); | ||
| var isLocal = address === '127.0.0.1' || | ||
| address === 'localhost' || | ||
| address.match(/^(0*:)+0*1$/); |
There was a problem hiding this comment.
OK, I added a comment. Does it help?
|
👍 |
|
I had a conversation with Trevor and changed the logic here to be much more restrictive. Instead of binding to a different address than the one the caller requested, it now returns an error code. However, this will actually break uProxy ... so please don't press "Merge" so we have time to update uProxy first! |
|
uProxy change here: UWNetworksLab/uProxy-lib#212 |
This address will always be either '127.0.0.1' or '0.0.0.0', because nsIUDPSocket::init only supports binding to localhost or all-interfaces.
| @@ -23,7 +38,7 @@ UDP_Firefox.prototype.bind = function(address, port, continuation) { | |||
|
|
|||
| UDP_Firefox.prototype.getInfo = function(continuation) { | |||
| var returnValue = { | |||
| localAddress: "localhost", | |||
| localAddress: this._nsIUDPSocket.localAddr.address, | |||
| localPort: this._nsIUDPSocket.port | |||
There was a problem hiding this comment.
It may be good to pull port from this._nsIUDPSocket.localAddr.port for consistency - from logging the tests it looks to have the same value as this._nsIUDPSocket.port, so it should work the same, but look more consistent and maybe inoculate us from weird edge cases.
|
Consider the port suggestion, but aside from that 👍 |
Return the actual bound address, not a hardcoded "localhost".
This address will always be either '127.0.0.1' or '0.0.0.0',
because nsIUDPSocket::init only supports binding to localhost
or all-interfaces.
Addresses #62 and #67
@trevj