Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jest workaround from test.js #25

Closed
todo bot opened this issue Feb 3, 2019 · 0 comments · Fixed by #51
Closed

Remove jest workaround from test.js #25

todo bot opened this issue Feb 3, 2019 · 0 comments · Fixed by #51
Labels
size/xs Very small change (1 - 10 lines) type/todo TODO item opened by the TODO bot type/tooling Tooling related issue (build, testing, ...)

Comments

@todo
Copy link

todo bot commented Feb 3, 2019

This workaround was added because of a problem with using jest 24 programmatically. See jestjs/jest#7704

web/scripts/test.js

Lines 4 to 9 in 776646a

* @todo Remove jest workaround from test.js
* @body This workaround was added because of a problem with using jest 24 programmatically. See https://github.com/facebook/jest/issues/7704
*/
require('jest/node_modules/jest-cli/build/cli');
// Do this as the first thing so that any code reading it knows the right env.

This issue was generated by todo based on a @todo comment in 776646a when #24 was merged. cc @freecloudio.
@todo todo bot added the type/todo TODO item opened by the TODO bot label Feb 3, 2019
@riesinger riesinger added type/tooling Tooling related issue (build, testing, ...) size/xs Very small change (1 - 10 lines) type/todo TODO item opened by the TODO bot and removed type/todo TODO item opened by the TODO bot labels Feb 5, 2019
riesinger added a commit that referenced this issue Mar 4, 2019
@riesinger
refactor(test): remove workaround for jest 24
e6f048b 
The workaround was needed because jest 24.0 had a dependency cycle and
therefore was problematic to import and use programatically.
See jestjs/jest#7704.

This closes #25.
@riesinger riesinger mentioned this issue Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
size/xs Very small change (1 - 10 lines) type/todo TODO item opened by the TODO bot type/tooling Tooling related issue (build, testing, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(test): remove workaround for jest 24 freecloudio/web
1 participant
@riesinger