Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameters to Reference #49

Merged
merged 1 commit into from
May 28, 2020
Merged

Add new parameters to Reference #49

merged 1 commit into from
May 28, 2020

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented May 28, 2020

With chipsalliance/firrtl#1350, Reference has acquired two additional parameters.
This fixes #48.

With chipsalliance/firrtl#1350, `Reference` has acquired two additional parameters.
This fixes #48.
@ucbjrl ucbjrl requested a review from chick May 28, 2020 19:39
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ucbjrl ucbjrl merged commit 09c9075 into master May 28, 2020
@ucbjrl ucbjrl deleted the fix_Reference_ref branch May 28, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore FIRRTL compatibility
2 participants