Skip to content

Commit

Permalink
sys/intr: remove questionable interrupt report
Browse files Browse the repository at this point in the history
The "???" interrupt doesn't appear useful any more, so remove it.

Differential Revision: https://reviews.freebsd.org/D37869
  • Loading branch information
ehem committed Jul 23, 2024
1 parent 6467c69 commit f83c369
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
5 changes: 1 addition & 4 deletions sys/powerpc/powerpc/intr_machdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ intr_init_sources(void *arg __unused)

powerpc_intrs = mallocarray(num_io_irqs, sizeof(*powerpc_intrs),
M_INTR, M_WAITOK | M_ZERO);
nintrcnt = 1 + mp_ncpus * 2;
nintrcnt = mp_ncpus * 2;
#ifdef COUNT_IPIS
if (mp_ncpus > 1)
nintrcnt += 8 * mp_ncpus;
Expand All @@ -175,9 +175,6 @@ intr_init_sources(void *arg __unused)
M_ZERO);
intrnames = mallocarray(nintrcnt, INTRNAME_LEN, M_INTR, M_WAITOK |
M_ZERO);

intrcnt_setname("???", 0);
intrcnt_index = 1;
}
/*
* This needs to happen before SI_SUB_CPU
Expand Down
6 changes: 1 addition & 5 deletions sys/x86/x86/intr_machdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,11 @@ intr_init_sources(void *arg)
#endif

/*
* - 1 ??? dummy counter.
* - 1 counter for each CPU for lapic timer.
* - 1 counter for each CPU for hypervisor drivers.
* - 8 counters for each CPU for IPI counters for SMP.
*/
nintrcnt = 1 + mp_ncpus * 2;
nintrcnt = mp_ncpus * 2;
#ifdef COUNT_IPIS
if (mp_ncpus > 1)
nintrcnt += 8 * mp_ncpus;
Expand All @@ -186,9 +185,6 @@ intr_init_sources(void *arg)
intrnames = mallocarray(nintrcnt, INTRNAME_LEN, M_INTR, M_WAITOK |
M_ZERO);

intrcnt_setname("???", 0);
intrcnt_index = 1;

/*
* NB: intrpic_lock is not held here to avoid LORs due to
* malloc() in intr_register_source(). However, we are still
Expand Down

0 comments on commit f83c369

Please sign in to comment.