Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #9 ("panic: <something>: called with spinlock or critical section held" on KabyLake) #39

Closed
wants to merge 3 commits into from

Conversation

wulf7
Copy link
Contributor

@wulf7 wulf7 commented Nov 15, 2020

This fixes several panics triggered by running of fence callbacks in critical section.

It includes:

  1. irq_work implementation via fast taskqueue: https://reviews.freebsd.org/D27171. Panic message is in review
  2. SYSINIT initialization of current for irq_work thread as it can not be done lazily by i915kms without extra patching.
  3. Asynchronous kfree() to use inside critical sections. This fixes panic from "panic: <something>: called with spinlock or critical section held" on KabyLake #9

It is possible that p. 2 and 3 should belong to LKPI rather than to drm-kmod.

@wulf7 wulf7 changed the title Fix issue #9 Fix issue #9 ("panic: <something>: called with spinlock or critical section held" on KabyLake) Nov 15, 2020
@0mp
Copy link
Member

0mp commented Jan 16, 2021

Potentially related to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250772.

@evadot
Copy link
Contributor

evadot commented Jan 17, 2021

Pushed with some modification (check was wrong in i915_request.c)
Thanks !

@evadot evadot closed this Jan 17, 2021
@0mp
Copy link
Member

0mp commented Jan 17, 2021

Thanks, @evadot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants