Skip to content
This repository has been archived by the owner on Aug 28, 2019. It is now read-only.

Added jquery and bootstrap's javascript #114

Closed
wants to merge 1 commit into from
Closed

Added jquery and bootstrap's javascript #114

wants to merge 1 commit into from

Conversation

elaine-jackson
Copy link
Contributor

This pull request adds jquery and bootstrap's javascript. This change is needed for pages that show examples utilizing jquery and bootstrap. Without adding jquery and bootstrap's javascript showing examples in action is not a possibility.

@Bouncey
Copy link
Member

Bouncey commented Aug 7, 2017

@nsuchy thanks for the pull request.

I will need to investigate further to see if there will be any conflicts between these libraries and react/react-bootstrap.

We use react-bootstrap for our UI, and it accomplishes all aspects of bootstrap.js without jQuery. I understand the need for these libs to correctly show working examples.

@BerkeleyTrue Did you manage to integrate these into the challenge framework without conflict?

@BerkeleyTrue
Copy link
Contributor

@Bouncey on fcc, challenges are run in their own isolated iframe. A challenge that requires jquery or bootstrap imports it into the iframe itself. This means it does not have a change to interfere with the rest of the site.

@Bouncey
Copy link
Member

Bouncey commented Aug 9, 2017

I'll have to have a think about it.

@elaine-jackson
Copy link
Contributor Author

@Bouncey I'm not sure if it's out of scope or even a possibility but maybe we could add an "imports" feature to the markdown parser so if a certain library is needed it'll be imported just for that one page. Thoughts?

@elaine-jackson
Copy link
Contributor Author

Closed in favor of #274

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants