Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

chore(challenges): fixed a minor spelling error #233

Merged
merged 1 commit into from
Aug 9, 2018
Merged

chore(challenges): fixed a minor spelling error #233

merged 1 commit into from
Aug 9, 2018

Conversation

lauren-van-sloun
Copy link
Contributor

Description

Fixed a minor spelling error ("a option" => "an option")

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue #17990

Closes #17990

Changed "a option" to "an option" in css-grid.json

ISSUES CLOSED: 17990
@moT01
Copy link
Member

moT01 commented Aug 9, 2018

@ashera138 looks good I think, that's my first time merging something so hopefully I did it correctly - You should maybe put in the description of the PR that you also changed all that spacing so the person reviewing it knows.

@lauren-van-sloun lauren-van-sloun deleted the Fix/MinorSpellingError branch August 10, 2018 00:09
@lauren-van-sloun
Copy link
Contributor Author

I actually noticed the extra white spaces after pushing (oops). I think maybe it was because I did the edit in Notepad++? I'm not sure.

Thanks again for helping me on my first pr! 👍

@moT01
Copy link
Member

moT01 commented Aug 10, 2018

Perhaps, you didn't deliberately add them I take? - I was going to say they should be deleted, but I noticed several other files shared that structure so I didn't think it was a problem. Thanks for contributing 👍

@lauren-van-sloun
Copy link
Contributor Author

Yeah, I didn't intentionally add them. And you're welcome. 😄

@scissorsneedfoodtoo
Copy link
Contributor

@ashera138, thanks again for your contribution! And thank you for taking over the QA and merge @moT01 👍

No need to worry about all of the extra line breaks. That's just the new prettier format that runs with the linter. Really threw me the first time, too!

@lauren-van-sloun
Copy link
Contributor Author

Oh alright, good to know. Thanks for mentioning that @scissorsneedfoodtoo. And thanks you guys for sharing an easy issue for a beginner to grab. 😃

@raisedadead
Copy link
Member

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants