Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: UDR api, server, processor #30

Merged
merged 31 commits into from
Jun 27, 2024
Merged

refactor: UDR api, server, processor #30

merged 31 commits into from
Jun 27, 2024

Conversation

ian60509
Copy link
Contributor

@ian60509 ian60509 commented Apr 28, 2024 •
edited
Loading

Description

  • new Server structure
  • init App with Server's method
  • refactor gin handler to only 2 layers: Handle.... -> ...Procedure
  • interface design
  • Integrate appRoutes, expoRoutes, eeRoutes, eeShortRoutes, subShortRoutes into Server method getDataRepositoryRoutes
  • graceful shutdown
  • CI check
  • Test with UE-simulator

@ian60509 ian60509 force-pushed the refactor/processor-consumer branch from 776a200 to 35e8603 Compare May 14, 2024 09:55
@andy89923 andy89923 self-requested a review May 28, 2024 04:15
@andy89923 andy89923 changed the title Refactor UDR api, server, processor refactor: UDR api, server, processor May 28, 2024
@ian-cs12-NYCU ian-cs12-NYCU force-pushed the refactor/processor-consumer branch 2 times, most recently from 6b19954 to 44119f9 Compare June 2, 2024 12:54
@ian60509 ian60509 marked this pull request as ready for review June 3, 2024 09:10
andy89923
andy89923 reviewed Jun 3, 2024
View reviewed changes
internal/sbi/consumer/consumer.go Outdated Show resolved Hide resolved
internal/sbi/api_sanity_test.go Outdated Show resolved Hide resolved
internal/sbi/api_sanity_test.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
ianchen0119
ianchen0119 reviewed Jun 5, 2024
View reviewed changes
pkg/service/init.go Outdated Show resolved Hide resolved
andy89923
andy89923 reviewed Jun 11, 2024
View reviewed changes
cmd/cmd Outdated Show resolved Hide resolved
andy89923
andy89923 reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please follow the Terminate Procedure like others.

internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
andy89923
andy89923 reviewed Jun 26, 2024
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
pkg/app/app.go Outdated Show resolved Hide resolved
andy89923
andy89923 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andy89923
Copy link
Contributor

The test for not implement function should also changed to HTTP.NotImplement

@ianchen0119
Copy link
Contributor

Hi @ian-cs12-NYCU
Please fix the build failed issue.

ianchen0119
ianchen0119 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ianchen0119 ianchen0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianchen0119 ianchen0119 merged commit 5d49a34 into free5gc:main Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-cs12-NYCU ian-cs12-NYCU ian-cs12-NYCU left review comments

@yccodr yccodr yccodr left review comments

@donald1218 donald1218 donald1218 approved these changes

@ianchen0119 ianchen0119 ianchen0119 approved these changes

@andy89923 andy89923 andy89923 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ian60509 @andy89923 @ianchen0119 @yccodr @donald1218 @ian-cs12-NYCU