New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible Subscription ID collision #23

Merged

tim-ywliu merged 2 commits into free5gc:main from GKnirps:subscription_id_collision

Sep 5, 2023

Contributor

GKnirps commented Aug 11, 2023

created subscription ID was in the range of 0 to 100, leading to possible collisions
this change changes the range to up to 2^128
it also uses a cryptographically secure RNG (though this is probably not important here)
I also took the liberty to address some semi-unhandled error cases

GKnirps added 2 commits

August 11, 2023 16:03


          Expand range for subsription IDs in NF management

e12d885

- also used a cryptographically secure RNG, which is
  probably not that important here


          Add missing error handling in nf_management.go

56731b8

tim-ywliu approved these changes

View reviewed changes

tim-ywliu merged commit ec6e777 into free5gc:main

4 checks passed

GKnirps deleted the subscription_id_collision branch

September 5, 2023 14:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet