Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to R17 openapi #140

Open
wants to merge 28 commits into
base: next
Choose a base branch
from
Open

feat: update to R17 openapi #140

wants to merge 28 commits into from

Conversation

donald1218
Copy link
Contributor

No description provided.

@donald1218 donald1218 marked this pull request as draft August 15, 2024 14:51
@donald1218 donald1218 marked this pull request as ready for review August 18, 2024 04:22
@andy89923 andy89923 changed the title Feat/amf openapi feat: update to R17 openapi Aug 22, 2024
ian60509
ian60509 reviewed Sep 9, 2024
View reviewed changes
internal/gmm/handler.go Outdated Show resolved Hide resolved
tim1207 and others added 18 commits October 17, 2024 06:38
@tim1207 @donald1218
fix: point to openapi-r17 package
bc9314f
@tim1207 @donald1218
fix : add Name string to Route and fix some models
970c596
@tim1207 @donald1218
fix : fix models to r17
c9ca57c
@donald1218
fix: change model in gmm handler and some sbi to r17
acb6ebd
@donald1218
fix: change model in pcf_service to r17 openapi
82ddb4d
@tim1207 @donald1218
fix: match models to r17 in sbi
aad55de
@donald1218
fix: replace amf_service opanapi model and add RelocateUEContext
84f5a0c
@donald1218
fix: add snssaitoextsnssai and change openapi in nrf_service
7094541
@donald1218
fix: change ausf_service openapi models and consumer pd
59c2189
@donald1218
fix: change smf_service openapi
a9b22b5
@donald1218
fix: change udm_service openapi models
c0a3cc1
@donald1218
fix: change opanapi model in notifier
38695bd
@donald1218
fix: add route name and new api
034f847
@donald1218
fix: change openapi in event_exposure and fix lint err
6d0b47f
@donald1218
fix: change openapi hash and remove unused code
257dcb6
@donald1218
fix: remove unuse import and fix return error and type assertion smf …
826e8a6 
…err response
@donald1218
fix: searchnfinstance res nil
cebb3db
@donald1218
fix: fixed nrf_deregister err type error
c42d133
@andy89923 andy89923 self-requested a review October 17, 2024 07:22
andy89923
andy89923 reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nnrf_NFDiscovery.SearchNFInstancesParamOpts's TargetNfType must be non nil.
This PR miss this at multiple places.

HanHongChen
HanHongChen reviewed Oct 28, 2024
View reviewed changes
internal/gmm/handler.go Outdated Show resolved Hide resolved
internal/gmm/handler.go Show resolved Hide resolved
internal/sbi/consumer/nssf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nssf_service.go Outdated Show resolved Hide resolved
internal/sbi/processor/notifier/subscription.go Outdated Show resolved Hide resolved
internal/sbi/consumer/udm_service.go Outdated Show resolved Hide resolved
@ianchen0119 ianchen0119 changed the base branch from main to next November 12, 2024 06:21
andy89923
andy89923 reviewed Nov 25, 2024
View reviewed changes
internal/sbi/consumer/pcf_service.go
err = openapi.ReportError("server no response")
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
reporterr := apiErr.Model().(Npcf_AMPolicy.ReportObservedEventTriggersForIndividualAMPolicyAssociationError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the type assertion

internal/sbi/consumer/pcf_service.go
return nil, openapi.ReportError("server no response")
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
createrr := apiErr.Model().(Npcf_AMPolicy.CreateIndividualAMPolicyAssociationError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type assertion

Suggested change
createrr := apiErr.Model().(Npcf_AMPolicy.CreateIndividualAMPolicyAssociationError)
creatErr := apiErr.Model().(Npcf_AMPolicy.CreateIndividualAMPolicyAssociationError)

internal/sbi/consumer/pcf_service.go
err = openapi.ReportError("server no response")
if apiErr, ok := err.(openapi.GenericOpenAPIError); ok {
// API error
deleteerr := apiErr.Model().(Npcf_AMPolicy.DeleteIndividualAMPolicyAssociationError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type assertion

Suggested change
deleteerr := apiErr.Model().(Npcf_AMPolicy.DeleteIndividualAMPolicyAssociationError)
deleteErr := apiErr.Model().(Npcf_AMPolicy.DeleteIndividualAMPolicyAssociationError)

internal/sbi/consumer/smf_service.go
err1 = localErr
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
posterr := apiErr.Model().(Nsmf_PDUSession.PostSmContextsError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type assertion

Suggested change
posterr := apiErr.Model().(Nsmf_PDUSession.PostSmContextsError)
postErr := apiErr.Model().(Nsmf_PDUSession.PostSmContextsError)

internal/sbi/consumer/smf_service.go
err1 = localErr
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
updateerr := apiErr.Model().(Nsmf_PDUSession.UpdateSmContextError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type assertion

Suggested change
updateerr := apiErr.Model().(Nsmf_PDUSession.UpdateSmContextError)
updateErr := apiErr.Model().(Nsmf_PDUSession.UpdateSmContextError)

internal/sbi/consumer/udm_service.go
err = localErr
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
geterr := apiErr.Model().(Nudm_SubscriberDataManagement.GetAmDataError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
geterr := apiErr.Model().(Nudm_SubscriberDataManagement.GetAmDataError)
getErr := apiErr.Model().(Nudm_SubscriberDataManagement.GetAmDataError)

internal/sbi/consumer/udm_service.go
err = localErr
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
getErr := apiErr.Model().(Nudm_SubscriberDataManagement.GetSmfSelDataError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type assertion

internal/sbi/consumer/udm_service.go
err = localErr
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
subcribeerr := apiErr.Model().(Nudm_SubscriberDataManagement.SubscribeError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
subcribeerr := apiErr.Model().(Nudm_SubscriberDataManagement.SubscribeError)
subcribeErr := apiErr.Model().(Nudm_SubscriberDataManagement.SubscribeError)

internal/sbi/consumer/udm_service.go
err = localErr
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
geterr := apiErr.Model().(Nudm_SubscriberDataManagement.GetNSSAIError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
geterr := apiErr.Model().(Nudm_SubscriberDataManagement.GetNSSAIError)
getErr := apiErr.Model().(Nudm_SubscriberDataManagement.GetNSSAIError)

internal/sbi/consumer/udm_service.go
err = localErr
if apiErr, ok := localErr.(openapi.GenericOpenAPIError); ok {
// API error
unsubcribeerr := apiErr.Model().(Nudm_SubscriberDataManagement.UnsubscribeError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unsubcribeerr := apiErr.Model().(Nudm_SubscriberDataManagement.UnsubscribeError)
unsubcribeErr := apiErr.Model().(Nudm_SubscriberDataManagement.UnsubscribeError)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanHongChen HanHongChen HanHongChen left review comments

@pf-lin pf-lin pf-lin left review comments

@tim1207 tim1207 tim1207 left review comments

@andy89923 andy89923 andy89923 left review comments

@ian60509 ian60509 ian60509 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@donald1218 @andy89923 @tim1207 @ian60509 @pf-lin @HanHongChen