Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlikely #364

Closed
wants to merge 2 commits into from
Closed

Unlikely #364

wants to merge 2 commits into from

Conversation

Trinitou
Copy link
Contributor

the unlikely attribute is used in the clap-host repo but is C++20 or higher (so not C++17 friendly)

I guess it's good to define it here(?)
Or should it rather be in the clap-host repository?

@abique
Copy link
Contributor

abique commented Nov 21, 2023

I'd rather avoid it.
Because it doesn't have the same syntax in C and C++. I think in C you have to do __unlikely__((expr)).
Also clap itself almost ship no code so it doesn't need it.

clap-helpers could have it.

@Trinitou
Copy link
Contributor Author

Ok, let's discuss it over there then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants