Skip to content

Commit

Permalink
Merge pull request #377 from glowcoil/draft-includes
Browse files Browse the repository at this point in the history
Do not include draft headers from clap.h
  • Loading branch information
abique authored Jan 8, 2024
2 parents a44b93b + dfcd4b5 commit 06d6c85
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 10 deletions.
4 changes: 4 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ Note: we kept the last draft factory ID in order to not break plugins already us

* [plugin-template.c](src/plugin-template.c): implement thread-safe plugin entry init counter

## Organization

* `clap.h` no longer includes headers from `ext/draft` or `factory/draft`. Draft extension and factory headers must now be explicitly included, either individually or via the `draft.h` header.

# Changes in 1.1.10

* [params.h](include/clap/ext/params.h): add `CLAP_PARAM_IS_ENUM` flag.
Expand Down
10 changes: 0 additions & 10 deletions include/clap/clap.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@
#include "factory/plugin-factory.h"
#include "factory/preset-discovery.h"

#include "factory/draft/plugin-invalidation.h"
#include "factory/draft/plugin-state-converter.h"

#include "plugin.h"
#include "plugin-features.h"
#include "host.h"
Expand Down Expand Up @@ -64,10 +61,3 @@
#include "ext/timer-support.h"
#include "ext/track-info.h"
#include "ext/voice-info.h"

#include "ext/draft/ambisonic.h"
#include "ext/draft/cv.h"
#include "ext/draft/resource-directory.h"
#include "ext/draft/triggers.h"
#include "ext/draft/tuning.h"
#include "ext/draft/extensible-audio-ports.h"
12 changes: 12 additions & 0 deletions include/clap/draft.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#pragma once

#include "factory/draft/plugin-invalidation.h"
#include "factory/draft/plugin-state-converter.h"

#include "ext/draft/ambisonic.h"
#include "ext/draft/cv.h"
#include "ext/draft/midi-mappings.h"

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / macos-latest-build

'ext/draft/midi-mappings.h' file not found

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / macos-latest-build

'ext/draft/midi-mappings.h' file not found

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / macos-latest-build

'ext/draft/midi-mappings.h' file not found

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / macos-latest-build

'ext/draft/midi-mappings.h' file not found

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / macos-latest-build

'ext/draft/midi-mappings.h' file not found

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / ubuntu-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory

Check failure on line 8 in include/clap/draft.h

View workflow job for this annotation

GitHub Actions / windows-latest-build

ext/draft/midi-mappings.h: No such file or directory
#include "ext/draft/resource-directory.h"
#include "ext/draft/triggers.h"
#include "ext/draft/tuning.h"
#include "ext/draft/extensible-audio-ports.h"
1 change: 1 addition & 0 deletions src/main.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include <clap/clap.h>
#include <clap/draft.h>

// The purpose of this file is to check that all headers compile
int main(int argc, char **argv) {
Expand Down
1 change: 1 addition & 0 deletions src/main.cc
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include <clap/clap.h>
#include <clap/draft.h>

// The purpose of this file is to check that all headers compile

Expand Down

0 comments on commit 06d6c85

Please sign in to comment.