-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aeson version requirement #15
Conversation
Yesod 1.4 uses Aeson 0.8.0.1, which makes this library incompatible. Bumping this to 0.9 matches Yesod's requirements.
yesod-core requires aeson >= 0.5, what is requiring >= 0.8? I have
|
Hmm, good question -- @gfontenot do you remember exactly / can you look again to see what is trying to bring in aeson 0.8? |
Here is the conflict I'm seeing:
We're requiring aeson in Carnival, but we're requiring |
So if I had to guess (knowing what I know about carnival's bin/setup), the initial line to install Edit: if we can somehow confirm this is the root cause, we should close this issue and pickup the discussion internally or via a Carnival issue. It's possible If that's true, then getting yesod-auth-oauth2 to allow newer aeson does feel like the right fix. |
yeah, the version bump is not necessary for everyone, but should be a good change |
I'm going to go ahead and merge this, even though it doesn't fix our issue on Carnival. For the curious, here's what we think was happening:
*I do not know why this doesn't bite more people, it doesn't seem to be a situation unique to us |
Not so!
PATH=.cabal-sandbox/bin:$PATH |
Also, if you use |
This is what we were missing! |
Bump aeson version requirement
Hmm. I just did that and it didn't work, it seemed to ignore the extra packages I passed... |
Well, now I don't know what's going on. @gregwebs, can you see if you can reproduce the following?
If so, it might be worth a Yesod issue. By poking at the options to the |
did you clear out your sandbox first? What do you mean ignored? It did not install them? |
That first case may have been a command-line fail, since I can't reproduce it now. I intend to delete the sandbox before everything I try. |
A solution to all these problems is to try to use stackage. However, it doesn't play that nicely with cabal sandbox. But we could distribute the stackage dependencies as a cabal.config to use during installation. |
I do see the same install error. |
After these past few days trying to get up on 1.4, I am considering Stackage. Day-to-day we use cabal freeze, so this is not an issue and we chose that instead of Stackage for fear of missing packages that we want/need. The reason we're having all these problems now is because we had to (temporarily) remove the Things are working with the executable-only packages outside of the sandbox, so I may just go with that for now. That said, I think what I've pasted above is an actual bug somewhere. Stackage or not, one should be able to successfully install these 4 things (alex, happy, yesod-bin, and a freshly scaffolded app) together in an empty sandbox, yeah? |
I installed all of the above with mongoDB dependencies. I think cabal is having trouble solving some of the postgres related dependencies. max-backjumps=-1 may reveal a real dependency problem, or it may just run until your OS kills it :) |
Haha, yeah found that out. It just spun for ~30 minutes before I killed it. |
Any plans to release this on Hackage? It seems to build fine from git and I don't see any other changes in the repo since. Hoauth2, who seemed to be the last holdouts amongst your dependencies, had their bounds bumped in 0.4.3. |
Sorry! I thought I had released it, doing so now. |
Thanks! |
Yesod 1.4 uses Aeson 0.8.0.1, which makes this library incompatible.
Bumping this to 0.9 matches Yesod's requirements.