Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

429 error handling and tests #312 #314

Merged
merged 2 commits into from
Jun 21, 2021
Merged

429 error handling and tests #312 #314

merged 2 commits into from
Jun 21, 2021

Conversation

timrichardson
Copy link
Contributor

for #312

@timrichardson timrichardson marked this pull request as ready for review June 19, 2021 03:02
@timrichardson
Copy link
Contributor Author

PS closes #297

freakboy3742
freakboy3742 approved these changes Jun 21, 2021
View reviewed changes
Copy link
Owner

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the patch!

@freakboy3742 freakboy3742 merged commit 4630e4e into freakboy3742:master Jun 21, 2021
@freakboy3742 freakboy3742 mentioned this pull request Jun 21, 2021
Closed
@SergeNasr
Copy link

Thanks a lot @timrichardson and @freakboy3742 !!

Would it be possible to cut a new release to to pull the fix into our codebase?

@freakboy3742
Copy link
Owner

@SergeNasr Done - v0.9.3 is up on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timrichardson @SergeNasr @freakboy3742