Fix get items is array #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 'authorizeAfter' function, an incorrect definition of the data format when calling the 'feathersUtils.getItemsIsArray' function resulted in the 'isArray' variable being incorrectly set to 'false', which resulted in the 'getOrFind' variable being incorrectly set to 'get'. As a result, it affected incorrect data filtering when the user requests data using the 'find' method with pagination enabled and a restriction on allowed fields.
In the 'authorizeAfter' function, an incorrect definition of the data format when calling the 'feathersUtils.getItemsIsArray' function resulted in the 'isArray' variable being incorrectly set to 'false', which resulted in the 'getOrFind' variable being incorrectly set to 'get'. As a result, it affected incorrect data filtering when the user requests data using the 'find' method with pagination enabled and a restriction on allowed fields. Fix #95
…r/feathers-casl into fix-find_with_pagination
|
Released as |
|
Hi @fratzinger, Thanks for the quick response and correction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @romaincomtet, hey @Servaker,
sorry for the delay.... thanks for the bug report in #95 and the nice PR #109! This was clearly a bug in feathers-utils which I fixed in
v3.1.3see fratzinger/feathers-utils@2ec7427.I reverted the
'result'/'automatic'change from #109 but kept the nice test.I'll release it in a minute.
Closes #109, Fix #95.