Skip to content

Commit

Permalink
Merge pull request #153 from frappe/develop
Browse files Browse the repository at this point in the history
chore: merge 'develop' into 'main'
  • Loading branch information
nextchamp-saqib authored Aug 9, 2023
2 parents bb40050 + c84dc6f commit 3262f30
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 11 deletions.
2 changes: 1 addition & 1 deletion frappe-ui
2 changes: 1 addition & 1 deletion frontend/src/components/ShareDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
placeholder="Add a team to share with"
:options="unauthorizedTeams"
:autofocus="false"
@change="handleAccessGrant"
@update:modelValue="handleAccessGrant"
/>
<div class="space-y-3">
<div class="font-medium text-gray-600">Teams with access</div>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/dashboard/DashboardQueryOption.vue
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ async function selectQuery() {
placeholder="Select a query"
:allowCreate="true"
:options="queryOptions"
@change="queryName = $event"
@update:modelValue="queryName = $event"
@createOption="createQuery"
/>
<div
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/query/Column/SimpleColumnPicker.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
v-model="simpleColumn.aggType"
:options="aggregations"
placeholder="Select aggregation type"
@change="onTypeSelect"
@update:modelValue="onTypeSelect"
/>
</div>
<div v-if="columnNeeded" class="space-y-1 text-sm text-gray-600">
Expand All @@ -16,7 +16,7 @@
:options="filteredColumns"
placeholder="Select a column..."
:emptyText="requiresNumberColumn ? 'No number columns' : 'No columns'"
@change="onColumnSelect"
@update:modelValue="onColumnSelect"
/>
</div>
<div class="space-y-1 text-sm text-gray-600">
Expand All @@ -35,7 +35,7 @@
v-model="simpleColumn.dateFormat"
:options="dateFormats.map((f) => ({ ...f, description: f.value }))"
placeholder="Select a date format..."
@change="selectDateFormat"
@update:modelValue="selectDateFormat"
/>
</div>
<div class="space-y-1 text-sm text-gray-600">
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/query/Table/TablePanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
v-model="newTable"
:options="query.tables.newTableOptions"
placeholder="Select a table..."
@change="addNewTable"
@update:modelValue="addNewTable"
/>
</div>
<Button icon="x" @click="addingTable = false"></Button>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/widgets/Bar/BarOptions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const valueOptions = computed(() => {
<ListPicker
:value="options.yAxis"
:options="valueOptions"
@change="options.yAxis = $event.map((item) => item.value)"
@update:modelValue="options.yAxis = $event.map((item) => item.value)"
/>
</div>
Expand Down
8 changes: 5 additions & 3 deletions frontend/src/widgets/Progress/Progress.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ const progressPercent = computed(() => {
>
<div class="h-fit w-full max-w-[22rem]">
<div>
<div class="text-gray-600">{{ props.options.title }}</div>
<div class="text-[34px] leading-tight">
<div class="w-full overflow-hidden text-ellipsis whitespace-nowrap leading-6">
{{ props.options.title }}
</div>
<div class="text-[28px] font-medium leading-8">
{{ props.options.prefix }}{{ formatValue(progress) }}{{ props.options.suffix }}
</div>
</div>
<div class="mb-1">
<div class="my-1">
<div class="flex justify-between text-xs tracking-wide text-gray-600">
<div>{{ progressPercent }}%</div>
<div>
Expand Down

0 comments on commit 3262f30

Please sign in to comment.