fix(Additional Salary): amount gets overwritten by salary component amount even if mapped from a reference document #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t after selecting it, only if reference doctype is not set
ruchamahabal
changed the title
ruchamahabal
approved these changes
Nov 19, 2024
ruchamahabal
pushed a commit
that referenced
this pull request
Nov 19, 2024
…onent amount (backport #2420) (#2429) Co-authored-by: Asmita Hase <[email protected]> Co-authored-by: Rucha Mahabal <[email protected]> fix(Additional Salary): amount gets overwritten by salary component amount even if mapped from a reference document (#2420)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Amount field in New Additional Salary Doctype gets overwritten by amount field in Salary Component after selecting salary component. This behaviour is ideal except for scenarios like creating a "deduction from salary" from "employee advance"
Before
While creating new additional salary
While creating deduction from salary
After
While creating new additional salary (same as before)
While creating deduction from salary: Deduction amount referencing the employee advance doctype isn't overweritten
Fix
Removed "fetch from" "Salary Component" Setting on amount field in Additional Salary Doctype
Added conditional fetching and setting based on referenced doctype
no-tests