Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PWA): green color for present days now shows up in the attendance calendar (backport #2400) #2402

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 8, 2024

Issue

Green colour for present days was missing from the attendance calendar.

Before

Screenshot 2024-11-08 at 12 24 43 PM

After

Screenshot 2024-11-08 at 2 45 32 PM

Fix:

Removed dynamic class names for colours
Changed colours classes for consistency
no-tests-required


This is an automatic backport of pull request #2400 done by Mergify.

2. made the colour shades more balanced

(cherry picked from commit b4087ce)
@mergify mergify bot requested a review from ruchamahabal as a code owner November 8, 2024 09:22
@ruchamahabal ruchamahabal merged commit 21870eb into version-15-hotfix Nov 8, 2024
8 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ruchamahabal ruchamahabal deleted the mergify/bp/version-15-hotfix/pr-2400 branch November 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants