fix: correct bank entry calculation with deductions and prevent multiple loan repayment deductions (backport #2347) #2348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced via #2283 & #2324 and loan flow.
Issue:
total_loan_repayment
was being subtracted multiple times for each salary detail, leading to an incorrectsalary_slip_total
in the bank entry.Resolution:
get_salary_slip_details
function to ensuretotal_loan_repayment
is fetched only once per unique salary slip.make_bank_entry
function, we separated thetotal_loan_repayment
deduction from the main loop, ensuring it’s only subtracted once per salary slip, after calculating the total of earnings and deductions.This is an automatic backport of pull request fix: correct bank entry calculation with deductions and prevent multiple loan repayment deductions #2347 done by Mergify.