Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appraisal_cycle): Value missing for Appraisal: Company while creating Appraisal from Appraisal Cycle #2336

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix(appraisal_cycle): Value missing for Appraisal: Company while creating Appraisal from Appraisal Cycle #2336

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d69d85
fix(appraisal_cycle): fetch company from appraisal cycle when creatin…
jabir-elat Oct 24, 2024
164222c
chore: fix linter
ruchamahabal Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hrms/hr/doctype/appraisal_cycle/appraisal_cycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def create_appraisals_for_cycle(appraisal_cycle: AppraisalCycle, publish_progres
appraisal = frappe.get_doc(
{
"doctype": "Appraisal",
"company": appraisal_cycle.company,
ruchamahabal marked this conversation as resolved.
Show resolved Hide resolved
"appraisal_template": employee.appraisal_template,
"employee": employee.employee,
"appraisal_cycle": appraisal_cycle.name,
Expand Down
Loading