feat: fetch leave encashment amount from Salary Structure Assignment #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix formatting and linting. |
if no amount is defined in salary structure assignment then fetch amount from salary structure for old records
remove unwanted indent from salary structure assignment json file
iamejaaz
force-pushed
the
ssa-leave-encashment-amount
branch
from
7a14e01
to
f3c4423
Compare
While editing, I encountered conflicts with the commits, so I created a new PR and closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1275
Reference #1275
#1287 (comment)
As suggested in this PR (#1287), fetch the amount from the salary structure assignment instead of the salary structure.
It will allow us to set employee-specific encashment amounts, just like different base and variable amounts.
The amount will be fetched from the Salary Structure in the Salary Structure Assignment Doctype if it is empty; otherwise, the user can manually enter the amount.
Leave Encashment
