Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Employee Checkin): set the form as dirty on fetching geolocation #2157

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

ruchamahabal
Copy link
Member

Before

Unable to save checkin after fetching geolocation post insert

image

After

Set the form as dirty on fetching geolocation

image

@ruchamahabal ruchamahabal merged commit b7ba4f5 into frappe:develop Sep 4, 2024
5 checks passed
mergify bot pushed a commit that referenced this pull request Sep 4, 2024
ruchamahabal added a commit that referenced this pull request Sep 4, 2024
…(backport #2157) (#2158)

(cherry picked from commit b7ba4f5)

Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Sep 4, 2024
## [15.28.2](v15.28.1...v15.28.2) (2024-09-04)

### Bug Fixes

* **Employee Checkin:** set the form as dirty on fetching geolocation (backport [#2157](#2157)) ([#2158](#2158)) ([3598ae9](3598ae9))
* **Payroll:** calculate loan repayment amount based on payroll end date instead of posting date (backport [#2154](#2154)) ([#2156](#2156)) ([020344d](020344d))
* **Payroll:** skip dependent component update if no formula is set (backport [#2152](#2152)) ([#2153](#2153)) ([190959f](190959f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant