fix(Payroll): multiline condition & formula eval failing #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sanitize condition & formula fields in structure doc reference to avoid accidental reference to unsanitized fields across functions regression: frappe#2088
…fter_submit` too - multiline formula updates error out on submitted doc because sanitization was only done on `before_validate`
ruchamahabal
added
backport version-15-hotfix
and removed
needs-tests
backport version-15-hotfix
labels
ruchamahabal
added a commit
that referenced
this pull request
Aug 31, 2024
…2138 fix(Payroll): multiline condition & formula eval failing (backport #2138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Regression #2088
Multiline condition & formula eval failing because the last update tries to parse dependent component formulas without the sanitized expression.
Multiline formula:
Fix
Sanitize condition & formula fields in salary structure doc reference to avoid accidental references to unsanitized fields across functions
Fix in salary structure: Multiline formula updates error out on submitted doc because sanitization was only done on
before_validate. Sanitize expression fields onbefore_update_after_submittoo