Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark translatable strings in setup fixtures #2129

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Aug 28, 2024

... without translating them. See frappe/frappe#27462 for details.

Also,

  • remove unused import click
  • move field definition from constant to function (because semgrep would complain about _ being used in global scope)

@barredterra barredterra changed the title fix: mark translatable string in setup fixtures fix: mark translatable strings in setup fixtures Aug 28, 2024
@ruchamahabal ruchamahabal merged commit 1726a1c into frappe:develop Sep 16, 2024
10 checks passed
mergify bot pushed a commit that referenced this pull request Sep 16, 2024
... without translating them

(cherry picked from commit 1726a1c)
ruchamahabal pushed a commit that referenced this pull request Sep 16, 2024
)

... without translating them

(cherry picked from commit 1726a1c)

Co-authored-by: Raffael Meyer <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Sep 18, 2024
# [15.29.0](v15.28.3...v15.29.0) (2024-09-18)

### Bug Fixes

* expire_allocation api endpoint by fetching allocation object (backport [#1576](#1576)) ([#2195](#2195)) ([a0e8ddf](a0e8ddf))
* **Income Tax Computation:** consideration of new employees without prexisting salary slips ([a2033c1](a2033c1))
* mark translatable strings in setup fixtures (backport [#2129](#2129)) ([#2196](#2196)) ([a61d8cf](a61d8cf))
* **Monthly Attendance Sheet:** consideration of None values while grouping ([00e57e1](00e57e1))
* remove default from Employee Leave Balance report (backport [#2172](#2172)) ([#2191](#2191)) ([028b1e1](028b1e1))
* show shift for month full of leaves ([11223ca](11223ca))
* year_start_date in Employee Advance Summary (backport [#2165](#2165)) ([#2193](#2193)) ([94ca0c5](94ca0c5))

### Features

* **Monthly Attendance Sheet:** add Include Company Descendants filter ([93a0431](93a0431))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants