Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setup wizard breaks for non-admin user during ERPNext setup on frappehr.com domains (backport #2100) #2101

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 21, 2024

Problem: hrms disables erpnext-specific roles after install.

This used to work fine earlier as FC used to login and run setup wizard as admin. But FC now logs the user in as the system manager and not as an admin, so erpnext setup breaks due to missing roles

telegram-cloud-photo-size-5-6208774860646235479-y

Solution: move disabling roles to setup_wizard_complete hook


This is an automatic backport of pull request #2100 done by [Mergify](https://mergify.com).

…rappehr.com domains (#2100)

- hrms disables erpnext-specific roles after install. FC now logs the user in as system manager and not as an admin, so erpnext setup breaks due to missing roles

- solution: move disabling roles to `setup_wizard_complete` hook

(cherry picked from commit 9baf711)

# Conflicts:
#	hrms/subscription_utils.py
@mergify mergify bot added the conflicts label Aug 21, 2024
@mergify mergify bot requested a review from ruchamahabal as a code owner August 21, 2024 05:49
Copy link
Contributor Author

mergify bot commented Aug 21, 2024

Cherry-pick of 9baf711 has failed:

On branch mergify/bp/version-14-hotfix/pr-2100
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 9baf7119e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hrms/hooks.py
	modified:   hrms/setup.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/subscription_utils.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-2100 branch August 21, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant