refactor: validate total weightage in all appraisal forms #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
added
backport version-14-hotfix
backport version-15-hotfix
and removed
needs-tests
labels
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
(cherry picked from commit bb1b916)
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
(cherry picked from commit bb1b916) # Conflicts: # hrms/hr/doctype/appraisal/appraisal.py
This was referenced Jul 15, 2024
ruchamahabal
added a commit
that referenced
this pull request
Jul 15, 2024
…1976) (#1978) (cherry picked from commit bb1b916) Co-authored-by: Rucha Mahabal <[email protected]>
ruchamahabal
added a commit
that referenced
this pull request
Jul 15, 2024
…1976) (#1977) * refactor: validate total weightage in all appraisal forms (#1976) (cherry picked from commit bb1b916) # Conflicts: # hrms/hr/doctype/appraisal/appraisal.py * chore: fix conflicts --------- Co-authored-by: Rucha Mahabal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation for total weightage exceeding 100 was missing in appraisal form. Created a mixin for it and used it everywhere