Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UX): validate missing Income Tax Slab in Salary Structure Assignment (backport #1912) #1914

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 25, 2024

Currently, the user only learns about missing income tax slabs in salary structure assignments when they run the payroll. By then the assignment is already submitted and changing it becomes difficult.

Validate this in the assignment itself if any tax component is found

image
This is an automatic backport of pull request #1912 done by [Mergify](https://mergify.com).

…ent (#1912)

* fix: validate missing income tax slab in Salary Structure Assignment

* test(fix): income tax slab mapping

(cherry picked from commit bb8b254)
@mergify mergify bot requested a review from ruchamahabal as a code owner June 25, 2024 04:29
@ruchamahabal ruchamahabal merged commit e9e3a16 into version-14-hotfix Jun 25, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-1912 branch June 25, 2024 04:55
frappe-pr-bot pushed a commit that referenced this pull request Jun 26, 2024
## [14.28.7](v14.28.6...v14.28.7) (2024-06-26)

### Bug Fixes

* **UX:** validate missing Income Tax Slab in Salary Structure Assignment (backport [#1912](#1912)) ([#1914](#1914)) ([e9e3a16](e9e3a16))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.28.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants