Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add attachment for each type of proof in income tax proof submission instead of one single attachment #1893

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

shinil-cloud
Copy link
Contributor

@shinil-cloud shinil-cloud commented Jun 12, 2024

Created the Employee Tax Exmption proof submission attachment option inside the child tabe.So employee can submit seperate proof in each categories.
feat: add attachment for each type of proof in income tax declaration instead of one single attachment
issue:#1822

Video Link komododecks.com/recordings/GpvGAtOI98Z9dOT9DK2X?onlyRecording=1

no-docs

@ruchamahabal ruchamahabal changed the title proof_changes feat: add attachment for each type of proof in income tax proof submission instead of one single attachment Jun 25, 2024
@ruchamahabal ruchamahabal merged commit 259e291 into frappe:develop Jun 25, 2024
7 of 10 checks passed
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
…ssion instead of one single attachment (#1893)

* proof_changes

* fix: fieldname, col widths in table + `toggle_display` code

---------

Co-authored-by: shiniln-cloud <[email protected]>
Co-authored-by: Rucha Mahabal <[email protected]>
(cherry picked from commit 259e291)

# Conflicts:
#	hrms/payroll/doctype/employee_tax_exemption_proof_submission_detail/employee_tax_exemption_proof_submission_detail.json
ruchamahabal added a commit that referenced this pull request Jun 25, 2024
…ssion instead of one single attachment (backport #1893) (#1921)

* feat: add attachment for each type of proof in income tax proof submission instead of one single attachment (#1893)

* proof_changes

* fix: fieldname, col widths in table + `toggle_display` code

---------

Co-authored-by: shiniln-cloud <[email protected]>
Co-authored-by: Rucha Mahabal <[email protected]>
(cherry picked from commit 259e291)

# Conflicts:
#	hrms/payroll/doctype/employee_tax_exemption_proof_submission_detail/employee_tax_exemption_proof_submission_detail.json

* chore: fix conflicts

---------

Co-authored-by: shinil <[email protected]>
Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Jun 26, 2024
# [15.23.0](v15.22.3...v15.23.0) (2024-06-26)

### Bug Fixes

* ignore links while adding lending docperms to ess (backport [#1916](#1916)) ([#1919](#1919)) ([198061a](198061a))
* TypeError in Salary Slip Creation Due to Uninitialized Loans Field (backport [#1909](#1909)) ([#1922](#1922)) ([7869b4a](7869b4a))
* **UX:** validate missing Income Tax Slab in Salary Structure Assignment (backport [#1912](#1912)) ([#1915](#1915)) ([04ec743](04ec743))

### Features

* add attachment for each type of proof in income tax proof submission instead of one single attachment (backport [#1893](#1893)) ([#1921](#1921)) ([1a92a66](1a92a66))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants